ChangeRequest #136

RawChannelDataListener: Checked exceptions for write() and close()

Added by achristian over 6 years ago. Updated over 5 years ago.

Status:ClosedStart date:07/18/2012
Priority:NormalDue date:
Assignee:achristian% Done:

100%

Category:RawChannelEstimated time:2.00 h
Target version:1.2.0Spent time:2.00 h

Description

When transfering files, it may happen that the write-action on the receiver side fails (due to underlying IO-Exception when f.i. writing to disk). Same when closing the raw channel via close().

SIMON currently does not offer error-handling for this. You may throw a runtime exception, but this will kill the worker-thread and may also kill the session.

It would be better to have a checked exception like "RawChannelException" or something similar.

So, write() and close() in RawChannelDataListener should be extended by f.i. "throws RawChannelException"

This will break the API. So this change will not happen in 1.1x, but 1.2.x development branch.

See also: http://dev.root1.de/boards/7/topics/638?r=639#message-639

Associated revisions

Revision 662
Added by achristian over 5 years ago

Fixed issue #136
Switched to Java 1.7
Added RawChannelException

History

#1 Updated by achristian over 6 years ago

  • Description updated (diff)

#2 Updated by achristian over 5 years ago

  • % Done changed from 0 to 100

Added checked RawChannelException to write/close call. See JavaDoc for RawChannel and RawChannelDataListener for more details.

#3 Updated by achristian over 5 years ago

  • Status changed from New to Closed

Also available in: Atom PDF